New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach typedConstructorPattern to ignore non-redefining unapplies #9462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dwijnand
force-pushed
the
patmat-unrelated-unapply
branch
from
January 29, 2021 09:40
0e6522a
to
a25a765
Compare
Fixed my boolean algebra mistake. |
lrytz
reviewed
Jan 29, 2021
Just recording the current behaviour, to confirm the next commit doesn't regress them.
dwijnand
force-pushed
the
patmat-unrelated-unapply
branch
from
January 29, 2021 20:58
a25a765
to
fc34bf2
Compare
dwijnand
commented
Feb 2, 2021
In pos/t12250.scala Foo defines an unapply which doesn't redefine the synthetic one. Thus unapply is overloaded. In the pattern being typed, the synthetic one is indeed the one seeked, so despite being overloaded, we should convertToCaseConstructor.
dwijnand
force-pushed
the
patmat-unrelated-unapply
branch
from
February 3, 2021 11:26
fc34bf2
to
0b8dd2a
Compare
Seth was ready to merge, but I wanted to review this detail, so it can be merged now once it's green. |
This was referenced Mar 12, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pos/t12250.scala Foo defines an unapply which doesn't redefine the
synthetic one. Thus unapply is overloaded. In the pattern being typed,
the synthetic one is indeed the one seeked, so despite being overloaded,
we should convertToCaseConstructor.
Fixes scala/bug#12250